From 187d2d85bee40b13efb1d207ce43e58a48b88328 Mon Sep 17 00:00:00 2001 From: Christy Perez Date: Thu, 11 May 2017 11:06:37 -0400 Subject: [PATCH] Moving the rest of runc to x/sys/unix Signed-off-by: Christy Perez --- checkpoint.go | 5 ++-- delete.go | 4 ++- kill.go | 72 ++++++++++++++++++++++++++------------------------ utils_linux.go | 5 ++-- 4 files changed, 46 insertions(+), 40 deletions(-) diff --git a/checkpoint.go b/checkpoint.go index 9b5663f37..788f33475 100644 --- a/checkpoint.go +++ b/checkpoint.go @@ -6,11 +6,12 @@ import ( "fmt" "strconv" "strings" - "syscall" "github.com/opencontainers/runc/libcontainer" "github.com/opencontainers/runtime-spec/specs-go" "github.com/urfave/cli" + + "golang.org/x/sys/unix" ) var checkpointCommand = cli.Command{ @@ -113,7 +114,7 @@ func setManageCgroupsMode(context *cli.Context, options *libcontainer.CriuOpts) } var namespaceMapping = map[specs.LinuxNamespaceType]int{ - specs.NetworkNamespace: syscall.CLONE_NEWNET, + specs.NetworkNamespace: unix.CLONE_NEWNET, } func setEmptyNsMask(context *cli.Context, options *libcontainer.CriuOpts) error { diff --git a/delete.go b/delete.go index 1e0b08f82..e8e4d5478 100644 --- a/delete.go +++ b/delete.go @@ -11,10 +11,12 @@ import ( "github.com/opencontainers/runc/libcontainer" "github.com/urfave/cli" + + "golang.org/x/sys/unix" ) func killContainer(container libcontainer.Container) error { - _ = container.Signal(syscall.SIGKILL, false) + _ = container.Signal(unix.SIGKILL, false) for i := 0; i < 100; i++ { time.Sleep(100 * time.Millisecond) if err := container.Signal(syscall.Signal(0), false); err != nil { diff --git a/kill.go b/kill.go index f80c4db78..53b7b1e9c 100644 --- a/kill.go +++ b/kill.go @@ -8,45 +8,47 @@ import ( "strings" "syscall" + "golang.org/x/sys/unix" + "github.com/urfave/cli" ) var signalMap = map[string]syscall.Signal{ - "ABRT": syscall.SIGABRT, - "ALRM": syscall.SIGALRM, - "BUS": syscall.SIGBUS, - "CHLD": syscall.SIGCHLD, - "CLD": syscall.SIGCLD, - "CONT": syscall.SIGCONT, - "FPE": syscall.SIGFPE, - "HUP": syscall.SIGHUP, - "ILL": syscall.SIGILL, - "INT": syscall.SIGINT, - "IO": syscall.SIGIO, - "IOT": syscall.SIGIOT, - "KILL": syscall.SIGKILL, - "PIPE": syscall.SIGPIPE, - "POLL": syscall.SIGPOLL, - "PROF": syscall.SIGPROF, - "PWR": syscall.SIGPWR, - "QUIT": syscall.SIGQUIT, - "SEGV": syscall.SIGSEGV, - "STKFLT": syscall.SIGSTKFLT, - "STOP": syscall.SIGSTOP, - "SYS": syscall.SIGSYS, - "TERM": syscall.SIGTERM, - "TRAP": syscall.SIGTRAP, - "TSTP": syscall.SIGTSTP, - "TTIN": syscall.SIGTTIN, - "TTOU": syscall.SIGTTOU, - "UNUSED": syscall.SIGUNUSED, - "URG": syscall.SIGURG, - "USR1": syscall.SIGUSR1, - "USR2": syscall.SIGUSR2, - "VTALRM": syscall.SIGVTALRM, - "WINCH": syscall.SIGWINCH, - "XCPU": syscall.SIGXCPU, - "XFSZ": syscall.SIGXFSZ, + "ABRT": unix.SIGABRT, + "ALRM": unix.SIGALRM, + "BUS": unix.SIGBUS, + "CHLD": unix.SIGCHLD, + "CLD": unix.SIGCLD, + "CONT": unix.SIGCONT, + "FPE": unix.SIGFPE, + "HUP": unix.SIGHUP, + "ILL": unix.SIGILL, + "INT": unix.SIGINT, + "IO": unix.SIGIO, + "IOT": unix.SIGIOT, + "KILL": unix.SIGKILL, + "PIPE": unix.SIGPIPE, + "POLL": unix.SIGPOLL, + "PROF": unix.SIGPROF, + "PWR": unix.SIGPWR, + "QUIT": unix.SIGQUIT, + "SEGV": unix.SIGSEGV, + "STKFLT": unix.SIGSTKFLT, + "STOP": unix.SIGSTOP, + "SYS": unix.SIGSYS, + "TERM": unix.SIGTERM, + "TRAP": unix.SIGTRAP, + "TSTP": unix.SIGTSTP, + "TTIN": unix.SIGTTIN, + "TTOU": unix.SIGTTOU, + "UNUSED": unix.SIGUNUSED, + "URG": unix.SIGURG, + "USR1": unix.SIGUSR1, + "USR2": unix.SIGUSR2, + "VTALRM": unix.SIGVTALRM, + "WINCH": unix.SIGWINCH, + "XCPU": unix.SIGXCPU, + "XFSZ": unix.SIGXFSZ, } var killCommand = cli.Command{ diff --git a/utils_linux.go b/utils_linux.go index a830542a3..feab01442 100644 --- a/utils_linux.go +++ b/utils_linux.go @@ -9,7 +9,6 @@ import ( "os" "path/filepath" "strconv" - "syscall" "github.com/Sirupsen/logrus" "github.com/coreos/go-systemd/activation" @@ -20,6 +19,8 @@ import ( "github.com/opencontainers/runc/libcontainer/utils" "github.com/opencontainers/runtime-spec/specs-go" "github.com/urfave/cli" + + "golang.org/x/sys/unix" ) var errEmptyID = errors.New("container id cannot be empty") @@ -316,7 +317,7 @@ func (r *runner) destroy() { } func (r *runner) terminate(p *libcontainer.Process) { - _ = p.Signal(syscall.SIGKILL) + _ = p.Signal(unix.SIGKILL) _, _ = p.Wait() }