From 21a005d074ad5a801d7818153fb236e3b07b039c Mon Sep 17 00:00:00 2001 From: Aleksa Sarai Date: Wed, 12 Jul 2017 05:53:38 +1000 Subject: [PATCH] list: stop casting unknown UIDs to their unicode values If a container is owned by a UID that is not listed in /etc/passwd, previously we would cast the UID to a string which contained a character with the unicode value of the UID. This is clearly wrong, switch to using fmt.Sprintf as intended. In addition, notate unknown users with a leading '#' in the column. This is necessary to ensure that a user is not under the impression that the UID is the same as a numeric username. Signed-off-by: Aleksa Sarai --- list.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/list.go b/list.go index 1c3b9aa83..0313d8cc2 100644 --- a/list.go +++ b/list.go @@ -135,7 +135,7 @@ func getContainers(context *cli.Context) ([]containerState, error) { stat := item.Sys().(*syscall.Stat_t) owner, err := user.LookupUid(int(stat.Uid)) if err != nil { - owner.Name = string(stat.Uid) + owner.Name = fmt.Sprintf("#%d", stat.Uid) } container, err := factory.Load(item.Name())