mirror/runc
1
0
Fork 0
mirror of https://github.com/opencontainers/runc.git synced 2026-07-10 21:53:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5355 from lifubang/backport-5353-to-release-1.5

Browse Source 
[release-1.5 backport] libct: Enforce nr_inodes=2 to fix Focal mount errors
This commit is contained in:
Rodrigo Campos Catelin
2026-06-30 14:16:00 +02:00
committed by GitHub
parent 04fea92cf0 b678b1f14c
commit 2c96f6ef86
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libcontainer/rootfs_linux.go
+12 -1
View File
@@ -1323,7 +1323,18 @@ func verifyDevNull(f *os.File) error {
// maskDir mounts a read-only tmpfs on top of the specified path.
func maskDir(path, mountLabel string) error {
return mount("tmpfs", path, "tmpfs", unix.MS_RDONLY, label.FormatMountLabel("nr_blocks=1,nr_inodes=1", mountLabel))
// On most kernels `nr_inodes=1` works fine. However, Ubuntu 20.04 (Focal) with
// the official 5.4 kernel carries a private patch in mm/shmem.c that rejects
// "nr_inodes<2", so let's keep `nr_inodes=2` here!
// For reference, search for "case Opt_nr_inodes" in:
// https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal/plain/mm/shmem.c?h=Ubuntu-5.4.0-216.236
err := mount("tmpfs", path, "tmpfs", unix.MS_RDONLY, label.FormatMountLabel("nr_blocks=1,nr_inodes=2", mountLabel))
// We don't know whether some kernels will fail with "nr_inodes=2",
// so let's fall back to mount a tmpfs without this option.
if errors.Is(err, unix.EINVAL) {
err = mount("tmpfs", path, "tmpfs", unix.MS_RDONLY, label.FormatMountLabel("nr_blocks=1", mountLabel))
}
return err
}
// maskPaths masks the top of the specified paths inside a container to avoid