From 34fd5f0e9f9723fd4ae36ce7cdabc9dc43c33181 Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Wed, 7 May 2025 20:21:22 -0700 Subject: [PATCH] gha/ci: allow validate/all-done to succeed for non-PRs When we run CI not on a pull request, the commit job is skipped, as a result, all-done is also skipped. To allow all-done to succeed, modify the commit job to succeed for non-PRs. Signed-off-by: Kir Kolyshkin (cherry picked from commit 43955a0d28b1f8748ddcc3fcb65fbbf3d2d52d27) Signed-off-by: Kir Kolyshkin --- .github/workflows/validate.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index a1ad2217d..faa7f1f8b 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -152,21 +152,24 @@ jobs: contents: read pull-requests: read runs-on: ubuntu-24.04 - # Only check commits on pull requests. - if: github.event_name == 'pull_request' steps: - name: get pr commits + if: github.event_name == 'pull_request' # Only check commits on pull requests. id: 'get-pr-commits' uses: tim-actions/get-pr-commits@v1.3.1 with: token: ${{ secrets.GITHUB_TOKEN }} - name: check subject line length + if: github.event_name == 'pull_request' # Only check commits on pull requests. uses: tim-actions/commit-message-checker-with-regex@v0.3.2 with: commits: ${{ steps.get-pr-commits.outputs.commits }} pattern: '^.{0,72}(\n.*)*$' error: 'Subject too long (max 72)' + - name: succeed (not a PR) + if: github.event_name != 'pull_request' + run: echo "Nothing to check here." cfmt: runs-on: ubuntu-24.04