From 392a221293f0598c474ca1572f417daf47f90fe2 Mon Sep 17 00:00:00 2001
From: Kir Kolyshkin <kolyshkin@gmail.com>
Date: Thu, 26 Feb 2026 11:25:17 -0800
Subject: [PATCH] libct/specconv: TestInitSystemdProps: use t.Run

Use t.Run for individual tests. Add missing desc fields.

Best reviewed with --ignore-all-space.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
---
 libcontainer/specconv/spec_linux_test.go | 60 +++++++++++++-----------
 1 file changed, 32 insertions(+), 28 deletions(-)

diff --git a/libcontainer/specconv/spec_linux_test.go b/libcontainer/specconv/spec_linux_test.go
index b96893c7f..e1a55319f 100644
--- a/libcontainer/specconv/spec_linux_test.go
+++ b/libcontainer/specconv/spec_linux_test.go
@@ -686,8 +686,9 @@ func TestInitSystemdProps(t *testing.T) {
 		exp  expT
 	}{
 		{
-			in:  inT{"org.systemd.property.TimeoutStopUSec", "uint64 123456789"},
-			exp: expT{false, "TimeoutStopUSec", uint64(123456789)},
+			desc: "convert USec to Sec (simple case)",
+			in:   inT{"org.systemd.property.TimeoutStopUSec", "uint64 123456789"},
+			exp:  expT{false, "TimeoutStopUSec", uint64(123456789)},
 		},
 		{
 			desc: "convert USec to Sec (default numeric type)",
@@ -750,8 +751,9 @@ func TestInitSystemdProps(t *testing.T) {
 			exp:  expT{false, "FOOSec", 123},
 		},
 		{
-			in:  inT{"org.systemd.property.CollectMode", "'inactive-or-failed'"},
-			exp: expT{false, "CollectMode", "inactive-or-failed"},
+			desc: "CollectMode",
+			in:   inT{"org.systemd.property.CollectMode", "'inactive-or-failed'"},
+			exp:  expT{false, "CollectMode", "inactive-or-failed"},
 		},
 		{
 			desc: "unrelated property",
@@ -778,33 +780,35 @@ func TestInitSystemdProps(t *testing.T) {
 	spec := &specs.Spec{}
 
 	for _, tc := range testCases {
-		spec.Annotations = map[string]string{tc.in.name: tc.in.value}
+		t.Run(tc.desc, func(t *testing.T) {
+			spec.Annotations = map[string]string{tc.in.name: tc.in.value}
 
-		outMap, err := initSystemdProps(spec)
-		// t.Logf("input %+v, expected %+v, got err:%v out:%+v", tc.in, tc.exp, err, outMap)
+			outMap, err := initSystemdProps(spec)
+			// t.Logf("input %+v, expected %+v, got err:%v out:%+v", tc.in, tc.exp, err, outMap)
 
-		if tc.exp.isErr != (err != nil) {
-			t.Errorf("input %+v, expecting error: %v, got %v", tc.in, tc.exp.isErr, err)
-		}
-		expLen := 1 // expect a single item
-		if tc.exp.name == "" {
-			expLen = 0 // expect nothing
-		}
-		if len(outMap) != expLen {
-			t.Fatalf("input %+v, expected %d, got %d entries: %v", tc.in, expLen, len(outMap), outMap)
-		}
-		if expLen == 0 {
-			continue
-		}
+			if tc.exp.isErr != (err != nil) {
+				t.Errorf("input %+v, expecting error: %v, got %v", tc.in, tc.exp.isErr, err)
+			}
+			expLen := 1 // expect a single item
+			if tc.exp.name == "" {
+				expLen = 0 // expect nothing
+			}
+			if len(outMap) != expLen {
+				t.Fatalf("input %+v, expected %d, got %d entries: %v", tc.in, expLen, len(outMap), outMap)
+			}
+			if expLen == 0 {
+				return // No more checks.
+			}
 
-		out := outMap[0]
-		if tc.exp.name != out.Name {
-			t.Errorf("input %+v, expecting name: %q, got %q", tc.in, tc.exp.name, out.Name)
-		}
-		expValue := dbus.MakeVariant(tc.exp.value).String()
-		if expValue != out.Value.String() {
-			t.Errorf("input %+v, expecting value: %s, got %s", tc.in, expValue, out.Value)
-		}
+			out := outMap[0]
+			if tc.exp.name != out.Name {
+				t.Errorf("input %+v, expecting name: %q, got %q", tc.in, tc.exp.name, out.Name)
+			}
+			expValue := dbus.MakeVariant(tc.exp.value).String()
+			if expValue != out.Value.String() {
+				t.Errorf("input %+v, expecting value: %s, got %s", tc.in, expValue, out.Value)
+			}
+		})
 	}
 }