From 568a309225fa203662296b7f3fdedac68f35391e Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Wed, 8 Apr 2026 15:30:58 -0700 Subject: [PATCH] libct/int: remove buffers.Stdin It is never used. Signed-off-by: Kir Kolyshkin --- libcontainer/integration/bench_test.go | 1 - libcontainer/integration/execin_test.go | 4 ---- libcontainer/integration/seccomp_test.go | 4 ---- libcontainer/integration/utils_test.go | 3 --- 4 files changed, 12 deletions(-) diff --git a/libcontainer/integration/bench_test.go b/libcontainer/integration/bench_test.go index 0375ee7f7..5499ee215 100644 --- a/libcontainer/integration/bench_test.go +++ b/libcontainer/integration/bench_test.go @@ -106,7 +106,6 @@ func BenchmarkExecInBigEnv(b *testing.B) { Cwd: "/", Args: []string{"env"}, Env: env, - Stdin: buffers.Stdin, Stdout: buffers.Stdout, Stderr: buffers.Stderr, } diff --git a/libcontainer/integration/execin_test.go b/libcontainer/integration/execin_test.go index 414dcf9ea..d28166292 100644 --- a/libcontainer/integration/execin_test.go +++ b/libcontainer/integration/execin_test.go @@ -49,7 +49,6 @@ func TestExecIn(t *testing.T) { Cwd: "/", Args: []string{"ps"}, Env: standardEnvironment, - Stdin: buffers.Stdin, Stdout: buffers.Stdout, Stderr: buffers.Stderr, } @@ -107,7 +106,6 @@ func testExecInRlimit(t *testing.T, userns bool) { Cwd: "/", Args: []string{"/bin/sh", "-c", "ulimit -n"}, Env: standardEnvironment, - Stdin: buffers.Stdin, Stdout: buffers.Stdout, Stderr: buffers.Stderr, Rlimits: []configs.Rlimit{ @@ -357,7 +355,6 @@ func TestExecInEnvironment(t *testing.T) { Cwd: "/", Args: []string{"/bin/env"}, Env: execEnv, - Stdin: buffers.Stdin, Stdout: buffers.Stdout, Stderr: buffers.Stderr, } @@ -483,7 +480,6 @@ func TestExecInOomScoreAdj(t *testing.T) { Cwd: "/", Args: []string{"/bin/sh", "-c", "cat /proc/self/oom_score_adj"}, Env: standardEnvironment, - Stdin: buffers.Stdin, Stdout: buffers.Stdout, Stderr: buffers.Stderr, } diff --git a/libcontainer/integration/seccomp_test.go b/libcontainer/integration/seccomp_test.go index 4e8e0912a..7ad040664 100644 --- a/libcontainer/integration/seccomp_test.go +++ b/libcontainer/integration/seccomp_test.go @@ -40,7 +40,6 @@ func TestSeccompDenySyslogWithErrno(t *testing.T) { Cwd: "/", Args: []string{"dmesg"}, Env: standardEnvironment, - Stdin: buffers.Stdin, Stdout: buffers.Stdout, Stderr: buffers.Stderr, Init: true, @@ -88,7 +87,6 @@ func TestSeccompDenySyslog(t *testing.T) { Cwd: "/", Args: []string{"dmesg"}, Env: standardEnvironment, - Stdin: buffers.Stdin, Stdout: buffers.Stdout, Stderr: buffers.Stderr, Init: true, @@ -143,7 +141,6 @@ func TestSeccompPermitWriteConditional(t *testing.T) { Cwd: "/", Args: []string{"busybox", "ls", "/"}, Env: standardEnvironment, - Stdin: buffers.Stdin, Stdout: buffers.Stdout, Stderr: buffers.Stderr, Init: true, @@ -195,7 +192,6 @@ func TestSeccompDenyWriteConditional(t *testing.T) { Cwd: "/", Args: []string{"busybox", "ls", "does_not_exist"}, Env: standardEnvironment, - Stdin: buffers.Stdin, Stdout: buffers.Stdout, Stderr: buffers.Stderr, Init: true, diff --git a/libcontainer/integration/utils_test.go b/libcontainer/integration/utils_test.go index b9407d2a4..346b5b733 100644 --- a/libcontainer/integration/utils_test.go +++ b/libcontainer/integration/utils_test.go @@ -55,14 +55,12 @@ func ptrInt(v int) *int { func newStdBuffers() *stdBuffers { return &stdBuffers{ - Stdin: bytes.NewBuffer(nil), Stdout: bytes.NewBuffer(nil), Stderr: bytes.NewBuffer(nil), } } type stdBuffers struct { - Stdin *bytes.Buffer Stdout *bytes.Buffer Stderr *bytes.Buffer } @@ -187,7 +185,6 @@ func runContainer(t testing.TB, config *configs.Config, args ...string) (buffers Cwd: "/", Args: args, Env: standardEnvironment, - Stdin: buffers.Stdin, Stdout: buffers.Stdout, Stderr: buffers.Stderr, Init: true,