chore(deps): upgrade urfave/cli from v1 to v3

Migrate from urfave/cli v1 (maintenance mode) to v3 to benefit from
active development, improved features, and long-term support.

Signed-off-by: lifubang <lifubang@acmcoder.com>

tests/cmd/pidfd-kill/pidfd-kill.go

@@ -5,13 +5,14 @@
 package main
 
 import (
+	"context"
 	"errors"
 	"fmt"
 	"net"
 	"os"
 	"os/signal"
 
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v3"
 	"golang.org/x/sys/unix"
 
 	"github.com/opencontainers/runc/internal/cmsg"
@@ -32,32 +33,32 @@ pidfd:
 )
 
 func main() {
-	app := cli.NewApp()
+	app := &cli.Command{}
 	app.Name = "pidfd-kill"
 	app.Usage = usage
 
 	app.Flags = []cli.Flag{
-		cli.StringFlag{
+		&cli.StringFlag{
 			Name:  "signal",
 			Value: "SIGKILL",
 			Usage: "Signal to send to the init process",
 		},
-		cli.StringFlag{
+		&cli.StringFlag{
 			Name:  "pid-file",
 			Value: "",
 			Usage: "Path to write the pidfd-kill process ID to",
 		},
 	}
 
-	app.Action = func(ctx *cli.Context) error {
-		args := ctx.Args()
+	app.Action = func(_ context.Context, cmd *cli.Command) error {
+		args := cmd.Args().Slice()
 		if len(args) != 1 {
 			return errors.New("required a single socket path")
 		}
 
-		socketFile := ctx.Args()[0]
+		socketFile := args[0]
 
-		pidFile := ctx.String("pid-file")
+		pidFile := cmd.String("pid-file")
 		if pidFile != "" {
 			pid := fmt.Sprintf("%d\n", os.Getpid())
 			if err := os.WriteFile(pidFile, []byte(pid), 0o644); err != nil {
@@ -66,7 +67,7 @@ func main() {
 			defer os.Remove(pidFile)
 		}
 
-		sigStr := ctx.String("signal")
+		sigStr := cmd.String("signal")
 		if sigStr == "" {
 			sigStr = "SIGKILL"
 		}
@@ -84,7 +85,7 @@ func main() {
 
 		return unix.PidfdSendSignal(int(pidfdFile.Fd()), sig, nil, 0)
 	}
-	if err := app.Run(os.Args); err != nil {
+	if err := app.Run(context.Background(), os.Args); err != nil {
 		fmt.Fprintln(os.Stderr, "fatal error:", err)
 		os.Exit(1)
 	}

tests/cmd/recvtty/recvtty.go

@@ -25,6 +25,7 @@
 package main
 
 import (
+	"context"
 	"errors"
 	"fmt"
 	"io"
@@ -34,7 +35,7 @@ import (
 	"sync"
 
 	"github.com/containerd/console"
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v3"
 
 	"github.com/opencontainers/runc/internal/cmsg"
 )
@@ -175,7 +176,7 @@ func handleNull(path string) error {
 }
 
 func main() {
-	app := cli.NewApp()
+	app := &cli.Command{}
 	app.Name = "recvtty"
 	app.Usage = usage
 
@@ -191,30 +192,31 @@ func main() {
 
 	// Set the flags.
 	app.Flags = []cli.Flag{
-		cli.StringFlag{
-			Name:  "mode, m",
-			Value: "single",
-			Usage: "Mode of operation (single or null)",
+		&cli.StringFlag{
+			Name:    "mode",
+			Aliases: []string{"m"},
+			Value:   "single",
+			Usage:   "Mode of operation (single or null)",
 		},
-		cli.StringFlag{
+		&cli.StringFlag{
 			Name:  "pid-file",
 			Value: "",
 			Usage: "Path to write daemon process ID to",
 		},
-		cli.BoolFlag{
+		&cli.BoolFlag{
 			Name:  "no-stdin",
 			Usage: "Disable stdin handling (no-op for null mode)",
 		},
 	}
 
-	app.Action = func(ctx *cli.Context) error {
-		args := ctx.Args()
+	app.Action = func(_ context.Context, cmd *cli.Command) error {
+		args := cmd.Args().Slice()
 		if len(args) != 1 {
 			return errors.New("need to specify a single socket path")
 		}
-		path := ctx.Args()[0]
+		path := args[0]
 
-		pidPath := ctx.String("pid-file")
+		pidPath := cmd.String("pid-file")
 		if pidPath != "" {
 			pid := fmt.Sprintf("%d\n", os.Getpid())
 			if err := os.WriteFile(pidPath, []byte(pid), 0o644); err != nil {
@@ -222,8 +224,8 @@ func main() {
 			}
 		}
 
-		noStdin := ctx.Bool("no-stdin")
-		switch ctx.String("mode") {
+		noStdin := cmd.Bool("no-stdin")
+		switch cmd.String("mode") {
 		case "single":
 			if err := handleSingle(path, noStdin); err != nil {
 				return err
@@ -233,11 +235,11 @@ func main() {
 				return err
 			}
 		default:
-			return fmt.Errorf("need to select a valid mode: %s", ctx.String("mode"))
+			return fmt.Errorf("need to select a valid mode: %s", cmd.String("mode"))
 		}
 		return nil
 	}
-	if err := app.Run(os.Args); err != nil {
+	if err := app.Run(context.Background(), os.Args); err != nil {
 		bail(err)
 	}
 }

tests/cmd/remap-rootfs/remap-rootfs.go

@@ -6,6 +6,7 @@
 package main
 
 import (
+	"context"
 	"encoding/json"
 	"errors"
 	"fmt"
@@ -13,7 +14,7 @@ import (
 	"path/filepath"
 	"syscall"
 
-	"github.com/urfave/cli"
+	"github.com/urfave/cli/v3"
 
 	"github.com/opencontainers/runtime-spec/specs-go"
 )
@@ -102,12 +103,12 @@ func remapRootfs(root string, uidMap, gidMap []specs.LinuxIDMapping) error {
 }
 
 func main() {
-	app := cli.NewApp()
+	app := &cli.Command{}
 	app.Name = "remap-rootfs"
 	app.Usage = usage
 
-	app.Action = func(ctx *cli.Context) error {
-		args := ctx.Args()
+	app.Action = func(_ context.Context, cmd *cli.Command) error {
+		args := cmd.Args().Slice()
 		if len(args) != 1 {
 			return errors.New("exactly one bundle argument must be provided")
 		}
@@ -141,7 +142,7 @@ func main() {
 
 		return remapRootfs(rootfs, uidMap, gidMap)
 	}
-	if err := app.Run(os.Args); err != nil {
+	if err := app.Run(context.Background(), os.Args); err != nil {
 		fmt.Fprintln(os.Stderr, "error:", err)
 		os.Exit(1)
 	}