From 598d8b73a5cdeabbd58649880d8fd752e46628c5 Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Sun, 9 Aug 2020 14:17:39 -0700 Subject: [PATCH] tests/int/checkpoint.bats: ignore SC2206 Ignore warnings like this: > In checkpoint.bats line 169: > PIDS_TO_KILL=($cpt_pid) > ^------^ SC2206: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. Since in all the cases we deal with either pids or fds, and they don't have spaces. Signed-off-by: Kir Kolyshkin --- tests/integration/checkpoint.bats | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/integration/checkpoint.bats b/tests/integration/checkpoint.bats index 81d21072f..4a6ea651a 100644 --- a/tests/integration/checkpoint.bats +++ b/tests/integration/checkpoint.bats @@ -41,6 +41,7 @@ function setup_pipes() { exec {in_r}/proc/self/fd/$pipe exec {pipe}>&- + # shellcheck disable=SC2206 FDS_TO_CLOSE=($in_r $in_w $out_r $out_w) } @@ -162,10 +163,12 @@ function simple_cr() { # shellcheck disable=SC2094 exec {lazy_r}/proc/self/fd/$pipe exec {pipe}>&- + # shellcheck disable=SC2206 FDS_TO_CLOSE+=($lazy_r $lazy_w) __runc --criu "$CRIU" checkpoint --lazy-pages --page-server 0.0.0.0:${port} --status-fd ${lazy_w} --work-path ./work-dir --image-path ./image-dir test_busybox & cpt_pid=$! + # shellcheck disable=SC2206 PIDS_TO_KILL=($cpt_pid) # wait for lazy page server to be ready @@ -184,6 +187,7 @@ function simple_cr() { # Start CRIU in lazy-daemon mode ${CRIU} lazy-pages --page-server --address 127.0.0.1 --port ${port} -D image-dir & lp_pid=$! + # shellcheck disable=SC2206 PIDS_TO_KILL+=($lp_pid) # Restore lazily from checkpoint.