mirror/runc
1
0
Fork 0
mirror of https://github.com/opencontainers/runc.git synced 2026-07-11 06:03:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Preventing containers from being unable to be deleted"

Browse Source 
This fixes random failures to start a container in conmon integration
tests (see issue 5151).

I guess we need to find another way to fix issue 4645.

This reverts commit 1b39997e73.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This commit is contained in:
Kir Kolyshkin
2026-03-05 18:35:57 -08:00
parent c1c788765c
commit 5996fe143a
1 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libcontainer/process_linux.go
-14
View File
@@ -784,20 +784,6 @@ func (p *initProcess) start() (retErr error) {
return fmt.Errorf("unable to start init: %w", err) return fmt.Errorf("unable to start init: %w", err)
} }
// If the runc-create process is terminated due to receiving SIGKILL signal,
// it may lead to the runc-init process leaking due
// to issues like cgroup freezing,
// and it cannot be cleaned up by runc delete/stop
// because the container lacks a state.json file.
// This typically occurs when higher-level
// container runtimes terminate the runc create process due to context cancellation or timeout.
// If the runc-create process terminates due to SIGKILL before
// reaching this line of code, we won't encounter the cgroup freezing issue.
_, err = p.container.updateState(nil)
if err != nil {
return fmt.Errorf("unable to store init state before creating cgroup: %w", err)
}
defer func() { defer func() {
if retErr != nil { if retErr != nil {
// Find out if init is killed by the kernel's OOM killer. // Find out if init is killed by the kernel's OOM killer.