From 59dd4cdee982e0dc1ba2a8a64cdd47d29a26cc8a Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Tue, 7 Apr 2026 10:53:37 -0700 Subject: [PATCH] tests: rename AUX_{DIR,UID} to ROOTLESS_AUX_* Also, fix the typo (AUX_DIX) in cleanup. Signed-off-by: Kir Kolyshkin (cherry picked from commit ac2a53be8e4c4752a9e43a50c3f5f8a292cca1da) Signed-off-by: Kir Kolyshkin --- tests/integration/cwd.bats | 22 +++++++++++----------- tests/rootless.sh | 16 ++++++++-------- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/tests/integration/cwd.bats b/tests/integration/cwd.bats index f1859623b..4c71c78c0 100644 --- a/tests/integration/cwd.bats +++ b/tests/integration/cwd.bats @@ -33,25 +33,25 @@ function teardown() { @test "runc create sets up user before chdir to cwd if needed" { requires rootless rootless_idmap - # Some setup for this test (AUX_DIR and AUX_UID) is done + # Some setup for this test (ROOTLESS_AUX_DIR and ROOTLESS_AUX_UID) is done # by rootless.sh. Check that setup is done... - if [[ ! -v AUX_UID || ! -v AUX_DIR || ! -d "$AUX_DIR" ]]; then - skip "bad/unset AUX_DIR/AUX_UID" + if [[ ! -v ROOTLESS_AUX_UID || ! -v ROOTLESS_AUX_DIR || ! -d "$ROOTLESS_AUX_DIR" ]]; then + skip "bad/unset ROOTLESS_AUX_DIR/ROOTLESS_AUX_UID" fi # ... and is correct, i.e. the current user - # does not have permission to access AUX_DIR. - if ls -l "$AUX_DIR" 2>/dev/null; then - skip "bad AUX_DIR permissions" + # does not have permission to access ROOTLESS_AUX_DIR. + if ls -l "$ROOTLESS_AUX_DIR" 2>/dev/null; then + skip "bad ROOTLESS_AUX_DIR permissions" fi update_config ' .mounts += [{ - source: "'"$AUX_DIR"'", - destination: "'"$AUX_DIR"'", + source: "'"$ROOTLESS_AUX_DIR"'", + destination: "'"$ROOTLESS_AUX_DIR"'", options: ["bind"] }] - | .process.user.uid = '"$AUX_UID"' - | .process.cwd = "'"$AUX_DIR"'" - | .process.args |= ["ls", "'"$AUX_DIR"'"]' + | .process.user.uid = '"$ROOTLESS_AUX_UID"' + | .process.cwd = "'"$ROOTLESS_AUX_DIR"'" + | .process.args |= ["ls", "'"$ROOTLESS_AUX_DIR"'"]' runc run test_busybox [ "$status" -eq 0 ] diff --git a/tests/rootless.sh b/tests/rootless.sh index ad24f4645..3bf83b360 100755 --- a/tests/rootless.sh +++ b/tests/rootless.sh @@ -54,15 +54,15 @@ function enable_idmap() { [ -e /usr/bin/unused-newuidmap ] && mv /usr/bin/{unused-,}newuidmap [ -e /usr/bin/unused-newgidmap ] && mv /usr/bin/{unused-,}newgidmap - # Create a directory owned by $AUX_UID inside container, to be used + # Create a directory owned by $ROOTLESS_AUX_UID inside container, to be used # by a test case in cwd.bats. This setup can't be done by the test itself, # as it needs root for chown. - export AUX_UID=1024 - AUX_DIR="$(mktemp -d)" + export ROOTLESS_AUX_UID=1024 + ROOTLESS_AUX_DIR="$(mktemp -d)" # 1000 is linux.uidMappings.containerID value, # as set by runc_rootless_idmap - chown "$((ROOTLESS_UIDMAP_START - 1000 + AUX_UID))" "$AUX_DIR" - export AUX_DIR + chown "$((ROOTLESS_UIDMAP_START - 1000 + ROOTLESS_AUX_UID))" "$ROOTLESS_AUX_DIR" + export ROOTLESS_AUX_DIR } function disable_idmap() { @@ -81,9 +81,9 @@ function disable_idmap() { } function cleanup() { - if [ -v AUX_DIR ]; then - rmdir "$AUX_DIR" - unset AUX_DIX + if [ -v ROOTLESS_AUX_DIR ]; then + rmdir "$ROOTLESS_AUX_DIR" + unset ROOTLESS_AUX_DIR fi }