mirror/runc
1
0
Fork 0
mirror of https://github.com/opencontainers/runc.git synced 2026-07-10 21:53:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5210 from lifubang/fix-signal-race

Browse Source 
Fix SIGCHLD race in signal handler setup
This commit is contained in:
lfbzhm
2026-04-02 09:38:46 +08:00
committed by GitHub
parent 5c9b6ac713 404181e4cc
commit 62d4f147e8
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
signals.go
+7 -4
View File
@@ -26,14 +26,17 @@ func newSignalHandler(enableSubreaper bool, notifySocket *notifySocket) chan *si
} }
} }
handler := make(chan *signalHandler) handler := make(chan *signalHandler)
// Ensure that we have a large buffer size so that we do not miss any
// signals in case we are not processing them fast enough.
s := make(chan os.Signal, signalBufferSize)
// signal.Notify is actually quite expensive, as it has to configure the // signal.Notify is actually quite expensive, as it has to configure the
// signal mask and add signal handlers for all signals (all ~65 of them). // signal mask and add signal handlers for all signals (all ~65 of them).
// So, defer this to a background thread while doing the rest of the io/tty // So, defer this to a background thread while doing the rest of the io/tty
// setup. // setup, except for SIGCHLD which is very important (see #5208).
signal.Notify(s, unix.SIGCHLD)
go func() { go func() {
// ensure that we have a large buffer size so that we do not miss any
// signals in case we are not processing them fast enough.
s := make(chan os.Signal, signalBufferSize)
// handle all signals for the process. // handle all signals for the process.
signal.Notify(s) signal.Notify(s)
handler <- &signalHandler{ handler <- &signalHandler{