mirror/runc
1
0
Fork 0
mirror of https://github.com/opencontainers/runc.git synced 2026-07-11 06:03:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

libct: better errors for hooks

Browse Source 
When a hook has failed, the error message looks like this:

> error running hook: error running hook #1: exit status 1, stdout: ...

The two problems here are:
1. it is impossible to know what kind of hook it was;
2. "error running hook" stuttering;

Change that to

> error running createContainer hook #1: exit status 1, stdout: ...

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This commit is contained in:
Kir Kolyshkin
2023-05-15 14:36:44 -07:00
parent 693d1c6ec4
commit 6a4870e4ac
8 changed files with 25 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libcontainer/process_linux.go
+4 -4
View File
@@ -536,10 +536,10 @@ func (p *initProcess) start() (retErr error) {
s.Status = specs.StateCreating
hooks := p.config.Config.Hooks
if err := hooks[configs.Prestart].RunHooks(s); err != nil {
if err := hooks.Run(configs.Prestart, s); err != nil {
return err
}
if err := hooks[configs.CreateRuntime].RunHooks(s); err != nil {
if err := hooks.Run(configs.CreateRuntime, s); err != nil {
return err
}
}
@@ -590,10 +590,10 @@ func (p *initProcess) start() (retErr error) {
s.Status = specs.StateCreating
hooks := p.config.Config.Hooks
if err := hooks[configs.Prestart].RunHooks(s); err != nil {
if err := hooks.Run(configs.Prestart, s); err != nil {
return err
}
if err := hooks[configs.CreateRuntime].RunHooks(s); err != nil {
if err := hooks.Run(configs.CreateRuntime, s); err != nil {
return err
}
}