From 72f463891d8e550ba0f80f3337092c1c84aab5a5 Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Tue, 5 Jan 2021 14:34:54 -0800 Subject: [PATCH] libct: add TODO about os.ErrProcessDone This is a new variable added by go 1.16 so we'll have to wait until 1.16 is minimally supported version, thus TODO for now. Signed-off-by: Kir Kolyshkin --- libcontainer/container_linux.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libcontainer/container_linux.go b/libcontainer/container_linux.go index 4dafa5636..3dca29e4c 100644 --- a/libcontainer/container_linux.go +++ b/libcontainer/container_linux.go @@ -2075,6 +2075,9 @@ func ignoreTerminateErrors(err error) error { if errors.As(err, &exitErr) { return nil } + // TODO: use errors.Is(err, os.ErrProcessDone) here and + // remove "process already finished" string comparison below + // once go 1.16 is minimally supported version. s := err.Error() if strings.Contains(s, "process already finished") ||