From c4eb0c61e12fc0b47e4e0f0e1fb5fda0e7c0a91d Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Wed, 15 Jan 2025 19:41:51 -0800 Subject: [PATCH] libct: createExecFifo: optimize Every time we call container.Config(), a new copy of struct Config is created and returned, and we do it twice here. Accessing container.config directly fixes this. Fixes: 805b8c73d ("Do not create exec fifo in factory.Create") Signed-off-by: Kir Kolyshkin --- libcontainer/container_linux.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libcontainer/container_linux.go b/libcontainer/container_linux.go index 26f523a90..a411d4081 100644 --- a/libcontainer/container_linux.go +++ b/libcontainer/container_linux.go @@ -432,11 +432,11 @@ func (c *Container) signal(s os.Signal) error { } func (c *Container) createExecFifo() (retErr error) { - rootuid, err := c.Config().HostRootUID() + rootuid, err := c.config.HostRootUID() if err != nil { return err } - rootgid, err := c.Config().HostRootGID() + rootgid, err := c.config.HostRootGID() if err != nil { return err }