From c84a878cac480fc71aff5abc56c0ace77d9b0f5b Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Wed, 7 Jan 2026 13:13:20 -0800 Subject: [PATCH] internal/sys: simplify WriteSysctls Apparently Write (and WriteString) must return an error (apparently io.ErrShortWrite) on short writes (see [1], [2]), so no explicit check for a short write is needed. While at it, use (*os.File).WriteString directly rather than io.WriteString. [1]: https://pkg.go.dev/os#File.Write [2]: https://pkg.go.dev/io#Writer Signed-off-by: Kir Kolyshkin --- internal/sys/sysctl_linux.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/internal/sys/sysctl_linux.go b/internal/sys/sysctl_linux.go index 96876a55f..e5f2805c2 100644 --- a/internal/sys/sysctl_linux.go +++ b/internal/sys/sysctl_linux.go @@ -2,7 +2,6 @@ package sys import ( "fmt" - "io" "os" "strings" @@ -42,10 +41,7 @@ func WriteSysctls(sysctls map[string]string) error { } defer sysctlFile.Close() - n, err := io.WriteString(sysctlFile, value) - if n != len(value) && err == nil { - err = fmt.Errorf("short write to file (%d bytes != %d bytes)", n, len(value)) - } + _, err = sysctlFile.WriteString(value) if err != nil { return fmt.Errorf("failed to write sysctl %s = %q: %w", key, value, err) }