mirror/runc
1
0
Fork 0
mirror of https://github.com/opencontainers/runc.git synced 2026-07-11 06:03:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Require two LGTMs for non-maintainer changes.

Browse Source 
Docker-DCO-1.1-Signed-off-by: Victor Marmol <vmarmol@google.com> (github: vmarmol)
This commit is contained in:
Victor Marmol
2014-06-17 10:18:08 -07:00
parent da2edd6068
commit fcce4884da
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CONTRIBUTORS_GUIDE.md
+5 -5
View File
@@ -112,12 +112,12 @@ and that all the tests pass.
libcontainer maintainers use LGTM (looks good to me) in comments on the code review libcontainer maintainers use LGTM (looks good to me) in comments on the code review
to indicate acceptance. to indicate acceptance.
A change requires LGTMs from at lease one maintainer of each A change requires LGTMs from at lease two maintainers. One of those must come from
component affected. For example, if a change affects `netlink/` and `security/`, it a maintainer of the component affected. For example, if a change affects `netlink/`
needs at least one LGTM from the maintainers of `netlink/` AND, separately, at and `security`, it needs at least one LGTM from a maintainer of each. Maintainers
least one LGTM from the maintainers of `security/`. only need one LGTM as presumably they LGTM their own change.
For more details see [MAINTAINERS.md](hack/MAINTAINERS.md) For more details see [MAINTAINERS.md](MAINTAINERS.md)
### Sign your work ### Sign your work
MAINTAINERS_GUIDE.md
+1 -1
View File
@@ -63,7 +63,7 @@ All decisions are pull requests, and the relevant maintainers make
decisions by accepting or refusing the pull request. Review and acceptance decisions by accepting or refusing the pull request. Review and acceptance
by anyone is denoted by adding a comment in the pull request: `LGTM`. by anyone is denoted by adding a comment in the pull request: `LGTM`.
However, only currently listed `MAINTAINERS` are counted towards the required However, only currently listed `MAINTAINERS` are counted towards the required
majority. two LGTMs.
libcontainer follows the timeless, highly efficient and totally unfair system libcontainer follows the timeless, highly efficient and totally unfair system
known as [Benevolent dictator for life](http://en.wikipedia.org/wiki/Benevolent_Dictator_for_Life), with Michael Crosby in the role of BDFL. known as [Benevolent dictator for life](http://en.wikipedia.org/wiki/Benevolent_Dictator_for_Life), with Michael Crosby in the role of BDFL.