3 Commits

Author	SHA1	Message	Date
Kir Kolyshkin	321073efde	runc exec -p: fix adding HOME to nil env ... Before commit 7dc24868, when process.env was nil, prepareEnv returned a flag telling HOME is not set, and it was added. Commit 7dc24868 moved the functionality of adding HOME into prepareEnv but did not properly handle nil case. As a result, runc exec -p with process.json having no env set resulted in an exec with no HOME set. Fix this, and add unit and integration tests. Fixes: 7dc24868 ("libct: switch to numeric UID/GID/groups") Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>	2026-04-29 23:15:18 -07:00
Kir Kolyshkin	d5307867f9	tests/int/env.bats: add test for runc exec -p ... All existing tests check runc run, and there is no single runc exec environment test except for one in exec.bats. Add it (no new issues found). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>	2026-04-29 23:15:10 -07:00
Rodrigo Campos	19c6515471	tests: Add env var tests ... This adds some e2e tests for environment variables set in the config.json. These were based on tests that failed on docker CI[1][2] after the refactor on 06f1e0765 ("libct: speedup process.Env handling") and some bugs that I had along the way trying to fix it. These tests pass with runc 1.2 too. [1]: https://github.com/moby/moby/blob/843e51459f14ebc964d349eba1013dc8a3e9d52e/integration-cli/docker_cli_run_test.go#L822-L843 [2]: https://github.com/moby/moby/blob/843e51459f14ebc964d349eba1013dc8a3e9d52e/integration-cli/docker_cli_links_test.go#L197-L204 Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>	2025-04-04 15:44:47 +02:00