mirror of
https://github.com/opencontainers/runc.git
synced 2026-07-11 06:03:57 +08:00
W. Trevor King
327a6367f0
The only .PHONY entry we *need* is for schema/validate, since that's a real file but we haven't told Make about its real dependencies (which involve complicated Go lookups). I'm personally in favor of using .PHONY for all targets that aren't on-disk files, because it hints to readers that the rule is not generating a file at the target. But there has been resistance to adding .PHONY entries to all such cases (e.g. [1,2]), so this commit brings us around to a internally-consistent "only use .PHONY when you always need it" position. That means that, for example, users who create files named 'clean' will turn 'clean' the target into a no-op, but runtime-spec maintainers are ok with that. [1]: https://github.com/opencontainers/runtime-spec/pull/791#issuecomment-300369882 [2]: https://github.com/opencontainers/runtime-spec/pull/791#issuecomment-300612827 Signed-off-by: W. Trevor King <wking@tremily.us>
51 lines
1.3 KiB
Makefile
51 lines
1.3 KiB
Makefile
GOOD_TESTS = $(wildcard test/good/*.json)
|
|
BAD_TESTS = $(wildcard test/bad/*.json)
|
|
|
|
default: validate
|
|
|
|
help:
|
|
@echo "Usage: make [target]"
|
|
@echo
|
|
@echo " * 'fmt' - format the json with indentation"
|
|
@echo " * 'help' - show this help information"
|
|
@echo " * 'validate' - build the validation tool"
|
|
|
|
fmt:
|
|
find . -name '*.json' -exec bash -c 'jq --indent 4 -M . {} > xx && mv xx {} || echo "skipping invalid {}"' \;
|
|
|
|
.PHONY: validate
|
|
validate: validate.go
|
|
go get -d ./...
|
|
go build ./validate.go
|
|
|
|
test: validate $(TESTS)
|
|
for TYPE in $$(ls test); \
|
|
do \
|
|
echo "testing $${TYPE}"; \
|
|
for FILE in $$(ls "test/$${TYPE}/good"); \
|
|
do \
|
|
echo " testing test/$${TYPE}/good/$${FILE}"; \
|
|
if ./validate "$${TYPE}-schema.json" "test/$${TYPE}/good/$${FILE}" ; \
|
|
then \
|
|
echo " received expected validation success" ; \
|
|
else \
|
|
echo " received unexpected validation failure" ; \
|
|
exit 1; \
|
|
fi \
|
|
done; \
|
|
for FILE in $$(ls "test/$${TYPE}/bad"); \
|
|
do \
|
|
echo " testing test/$${TYPE}/bad/$${FILE}"; \
|
|
if ./validate "$${TYPE}-schema.json" "test/$${TYPE}/good/$${FILE}" ; \
|
|
then \
|
|
echo " received unexpected validation success" ; \
|
|
exit 1; \
|
|
else \
|
|
echo " received expected validation failure" ; \
|
|
fi \
|
|
done; \
|
|
done
|
|
|
|
clean:
|
|
rm -f validate
|