Brian Goff 7632c4585f Fix for race from error on process start ...

This rather naively fixes an error observed where a processes stdio
streams are not written to when there is an error upon starting up the
process, such as when the executable doesn't exist within the
container's rootfs.

Before the "fix", when an error occurred on start, `terminate` is called
immediately, which calls `cmd.Process.Kill()`, then calling `Wait()` on
the process. In some cases when this `Kill` is called the stdio stream
have not yet been written to, causing non-deterministic output. The
error itself is properly preserved but users attached to the process
will not see this error.

With the fix it is just calling `Wait()` when an error occurs rather
than trying to `Kill()` the process first. This seems to preserve stdio.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

2015-10-07 21:28:26 -04:00

..

checkpoint_test.go

integration: show criu logs in a error case

2015-07-30 21:01:09 +03:00

doc.go

Move libcontainer into subdirectory

2015-06-21 19:29:15 -07:00

exec_test.go

exec_test.go: Test case for rootfsPropagation="private"

2015-10-01 17:03:02 -04:00

execin_test.go

Fix for race from error on process start

2015-10-07 21:28:26 -04:00

init_test.go

Update import paths for new repository

2015-06-21 19:29:59 -07:00

seccomp_test.go

make localtest failure on removing seccomp flag

2015-09-12 14:43:55 +05:30

template_test.go

Add CAP prefix for capabilities

2015-09-15 14:43:03 -04:00

utils_test.go

test: propagate the error to the caller

2015-07-25 22:25:43 +08:00