mirror of
https://github.com/opencontainers/runc.git
synced 2026-07-11 06:03:57 +08:00
Kir Kolyshkin
f5a2c9cced
The "runc run [device cgroup allow rm block device]" test calls lsblk three times to get device name, minor and major number. This creates a potential problem when the devices are changed between the calls. Simplify the code by using bash read together with IFS (as there's no way to have lsblk output MAJOR:MINOR pair without a semicolon). Note that head -n 1 is not needed as read already reads a single line. [v2: don't use PATH as CentOS7's lsblk does not support it.] Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
111 lines
3.4 KiB
Bash
111 lines
3.4 KiB
Bash
#!/usr/bin/env bats
|
|
|
|
load helpers
|
|
|
|
function setup() {
|
|
setup_busybox
|
|
}
|
|
|
|
function teardown() {
|
|
teardown_bundle
|
|
}
|
|
|
|
@test "runc run [redundant default /dev/tty]" {
|
|
update_config ' .linux.devices += [{"path": "/dev/tty", "type": "c", "major": 5, "minor": 0}]
|
|
| .process.args |= ["ls", "-lLn", "/dev/tty"]'
|
|
|
|
runc run test_dev
|
|
[ "$status" -eq 0 ]
|
|
|
|
if [[ "$ROOTLESS" -ne 0 ]]; then
|
|
[[ "${lines[0]}" =~ "crw-rw-rw".+"1".+"65534".+"65534".+"5,".+"0".+"/dev/tty" ]]
|
|
else
|
|
[[ "${lines[0]}" =~ "crw-rw-rw".+"1".+"0".+"0".+"5,".+"0".+"/dev/tty" ]]
|
|
fi
|
|
}
|
|
|
|
@test "runc run [redundant default /dev/ptmx]" {
|
|
update_config ' .linux.devices += [{"path": "/dev/ptmx", "type": "c", "major": 5, "minor": 2}]
|
|
| .process.args |= ["ls", "-lLn", "/dev/ptmx"]'
|
|
|
|
runc run test_dev
|
|
[ "$status" -eq 0 ]
|
|
[[ "${lines[0]}" =~ "crw-rw-rw".+"1".+"0".+"0".+"5,".+"2".+"/dev/ptmx" ]]
|
|
}
|
|
|
|
@test "runc run [device cgroup deny]" {
|
|
requires root
|
|
|
|
update_config ' .linux.resources.devices = [{"allow": false, "access": "rwm"}]
|
|
| .linux.devices = [{"path": "/dev/kmsg", "type": "c", "major": 1, "minor": 11}]
|
|
| .process.args |= ["sh"]'
|
|
|
|
runc run -d --console-socket "$CONSOLE_SOCKET" test_deny
|
|
[ "$status" -eq 0 ]
|
|
|
|
# test write
|
|
runc exec test_deny sh -c 'hostname | tee /dev/kmsg'
|
|
[ "$status" -eq 1 ]
|
|
[[ "${output}" == *'Operation not permitted'* ]]
|
|
|
|
# test read
|
|
runc exec test_deny sh -c 'head -n 1 /dev/kmsg'
|
|
[ "$status" -eq 1 ]
|
|
[[ "${output}" == *'Operation not permitted'* ]]
|
|
}
|
|
|
|
@test "runc run [device cgroup allow rw char device]" {
|
|
requires root
|
|
|
|
update_config ' .linux.resources.devices = [{"allow": false, "access": "rwm"},{"allow": true, "type": "c", "major": 1, "minor": 11, "access": "rw"}]
|
|
| .linux.devices = [{"path": "/dev/kmsg", "type": "c", "major": 1, "minor": 11}]
|
|
| .process.args |= ["sh"]
|
|
| .hostname = "myhostname"'
|
|
|
|
runc run -d --console-socket "$CONSOLE_SOCKET" test_allow_char
|
|
[ "$status" -eq 0 ]
|
|
|
|
# test write
|
|
runc exec test_allow_char sh -c 'hostname | tee /dev/kmsg'
|
|
[ "$status" -eq 0 ]
|
|
[[ "${lines[0]}" == *'myhostname'* ]]
|
|
|
|
# test read
|
|
runc exec test_allow_char sh -c 'head -n 1 /dev/kmsg'
|
|
[ "$status" -eq 0 ]
|
|
|
|
# test access
|
|
TEST_NAME="dev_access_test"
|
|
gcc -static -o "rootfs/bin/${TEST_NAME}" "${TESTDATA}/${TEST_NAME}.c"
|
|
runc exec test_allow_char sh -c "${TEST_NAME} /dev/kmsg"
|
|
[ "$status" -eq 0 ]
|
|
}
|
|
|
|
@test "runc run [device cgroup allow rm block device]" {
|
|
requires root
|
|
|
|
# Get the first block device.
|
|
IFS=$' \t:' read -r device major minor <<<"$(lsblk -nd -o NAME,MAJ:MIN)"
|
|
# Could have used -o PATH but lsblk from CentOS 7 does not have it.
|
|
device="/dev/$device"
|
|
|
|
update_config ' .linux.resources.devices = [{"allow": false, "access": "rwm"},{"allow": true, "type": "b", "major": '"$major"', "minor": '"$minor"', "access": "rwm"}]
|
|
| .linux.devices = [{"path": "'"$device"'", "type": "b", "major": '"$major"', "minor": '"$minor"'}]
|
|
| .process.args |= ["sh"]
|
|
| .process.capabilities.bounding += ["CAP_MKNOD"]
|
|
| .process.capabilities.effective += ["CAP_MKNOD"]
|
|
| .process.capabilities.inheritable += ["CAP_MKNOD"]
|
|
| .process.capabilities.permitted += ["CAP_MKNOD"]'
|
|
|
|
runc run -d --console-socket "$CONSOLE_SOCKET" test_allow_block
|
|
[ "$status" -eq 0 ]
|
|
|
|
# test mknod
|
|
runc exec test_allow_block sh -c 'mknod /dev/fooblock b '"$major"' '"$minor"''
|
|
[ "$status" -eq 0 ]
|
|
|
|
# test read
|
|
runc exec test_allow_block sh -c 'fdisk -l '"$device"''
|
|
[ "$status" -eq 0 ]
|
|
}
|