mirror of
https://github.com/opencontainers/runc.git
synced 2026-07-11 14:13:58 +08:00
Aleksa Sarai
95a59bf206
(mode&S_IFCHR == S_IFCHR) is the wrong way of checking the type of an inode because the S_IF* bits are actually not a bitmask and instead must be checked using S_IF*. This bug was neatly hidden behind a (major == 0) sanity-check but that was removed by [1]. In addition, add a test that makes sure that HostDevices() doesn't give rubbish results -- because we broke this and fixed this before[2]. [1]:24388be71e("configs: use different types for .Devices and .Resources.Devices") [2]:3ed492ad33("Handle non-devices correctly in DeviceFromPath") Fixes:b0d014d0e1("libcontainer: one more switch from syscall to x/sys/unix") Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
105 lines
2.4 KiB
Go
105 lines
2.4 KiB
Go
package devices
|
|
|
|
import (
|
|
"errors"
|
|
"io/ioutil"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/opencontainers/runc/libcontainer/configs"
|
|
"golang.org/x/sys/unix"
|
|
)
|
|
|
|
func cleanupTest() {
|
|
unixLstat = unix.Lstat
|
|
ioutilReadDir = ioutil.ReadDir
|
|
}
|
|
|
|
func TestDeviceFromPathLstatFailure(t *testing.T) {
|
|
testError := errors.New("test error")
|
|
|
|
// Override unix.Lstat to inject error.
|
|
unixLstat = func(path string, stat *unix.Stat_t) error {
|
|
return testError
|
|
}
|
|
defer cleanupTest()
|
|
|
|
_, err := DeviceFromPath("", "")
|
|
if err != testError {
|
|
t.Fatalf("Unexpected error %v, expected %v", err, testError)
|
|
}
|
|
}
|
|
|
|
func TestHostDevicesIoutilReadDirFailure(t *testing.T) {
|
|
testError := errors.New("test error")
|
|
|
|
// Override ioutil.ReadDir to inject error.
|
|
ioutilReadDir = func(dirname string) ([]os.FileInfo, error) {
|
|
return nil, testError
|
|
}
|
|
defer cleanupTest()
|
|
|
|
_, err := HostDevices()
|
|
if err != testError {
|
|
t.Fatalf("Unexpected error %v, expected %v", err, testError)
|
|
}
|
|
}
|
|
|
|
func TestHostDevicesIoutilReadDirDeepFailure(t *testing.T) {
|
|
testError := errors.New("test error")
|
|
called := false
|
|
|
|
// Override ioutil.ReadDir to inject error after the first call.
|
|
ioutilReadDir = func(dirname string) ([]os.FileInfo, error) {
|
|
if called {
|
|
return nil, testError
|
|
}
|
|
called = true
|
|
|
|
// Provoke a second call.
|
|
fi, err := os.Lstat("/tmp")
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error %v", err)
|
|
}
|
|
|
|
return []os.FileInfo{fi}, nil
|
|
}
|
|
defer cleanupTest()
|
|
|
|
_, err := HostDevices()
|
|
if err != testError {
|
|
t.Fatalf("Unexpected error %v, expected %v", err, testError)
|
|
}
|
|
}
|
|
|
|
func TestHostDevicesAllValid(t *testing.T) {
|
|
devices, err := HostDevices()
|
|
if err != nil {
|
|
t.Fatalf("failed to get host devices: %v", err)
|
|
}
|
|
|
|
for _, device := range devices {
|
|
// Devices can't have major number 0.
|
|
if device.Major == 0 {
|
|
t.Errorf("device entry %+v has zero major number", device)
|
|
}
|
|
// Devices should only have file modes that correspond to their type.
|
|
var expectedType os.FileMode
|
|
switch device.Type {
|
|
case configs.BlockDevice:
|
|
expectedType = unix.S_IFBLK
|
|
case configs.CharDevice:
|
|
expectedType = unix.S_IFCHR
|
|
case configs.FifoDevice:
|
|
t.Logf("fifo devices shouldn't show up from HostDevices")
|
|
fallthrough
|
|
default:
|
|
t.Errorf("device entry %+v has unexpected type %v", device, device.Type)
|
|
}
|
|
gotType := device.FileMode & unix.S_IFMT
|
|
if expectedType != gotType {
|
|
t.Errorf("device entry %+v has mismatched types (expected %#x, got %#x)", device, expectedType, gotType)
|
|
}
|
|
}
|
|
}
|