mirror of
https://github.com/opencontainers/runc.git
synced 2026-07-12 09:46:25 +08:00
Kir Kolyshkin
5ab0588432
This simplifies and optimizes getting container images used for tests. Currently, we have three different ways of getting images: 1. (for hello-world) the image is in this repo under tests/integration/testdata. 2. (for busybox) download it from github (the repo that is used for preparing official Docker image) using curl. 3. (for debian) download from Docker hub, using skopeo and umoci. To further complicate things, we have to do this downloading in multiple scenarios (at least 4): locally, in github CI, from Dockefile, inside a Vagrant VM. For each scenario, we have to install skopeo and umoci, and those two are not yet universally available for all the distros that we use. Yet another complication is those images are used for tests/integration (bats-driven tests) as well as for libcontainer/integration (go tests). The tests in libcontainer/integration rely on busybox being available from /busybox, and the bats tests just download the images to a temporary location during every run. It is also hard to support CI for other architectures, because all the machinery for preparing images is so complicated. This commit is an attempt to simplify and optimize getting images, mostly by getting rid of skopeo and umoci dependencies, but also by moving the download logic into one small shell script, which is used from all the places. Benefits: - images (if not present) are only downloaded once; - same images are used for both kind of tests (go and bats); - same images are used for local and inside-docker tests (because source directory is mounted into container); - the download logic is located within 1 simple shell script. [v2: fix eval; more doc to get-images; print URL if curl failed] [v3: use "slim" debian, twice as small] [v4: fix not using $image in setup_bundle] [v5: don't remove TESTDATA from helpers.bash] [v6: add i386 support] Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
64 lines
2.0 KiB
Bash
64 lines
2.0 KiB
Bash
#!/usr/bin/env bats
|
|
|
|
load helpers
|
|
|
|
# CR = CreateRuntime
|
|
# CC = CreataContainer
|
|
HOOKLIBCR=librunc-hooks-create-runtime.so
|
|
HOOKLIBCC=librunc-hooks-create-container.so
|
|
LIBPATH="$DEBIAN_BUNDLE/rootfs/lib/"
|
|
|
|
function setup() {
|
|
umount "$LIBPATH"/$HOOKLIBCR.1.0.0 &>/dev/null || true
|
|
umount "$LIBPATH"/$HOOKLIBCC.1.0.0 &>/dev/null || true
|
|
|
|
requires root no_systemd
|
|
|
|
teardown_debian
|
|
setup_debian
|
|
}
|
|
|
|
function teardown() {
|
|
umount "$LIBPATH"/$HOOKLIBCR.1.0.0 &>/dev/null || true
|
|
umount "$LIBPATH"/$HOOKLIBCC.1.0.0 &>/dev/null || true
|
|
|
|
rm -f $HOOKLIBCR.1.0.0 $HOOKLIBCC.1.0.0
|
|
teardown_debian
|
|
}
|
|
|
|
@test "runc run (hooks library tests)" {
|
|
# setup some dummy libs
|
|
gcc -shared -Wl,-soname,librunc-hooks-create-runtime.so.1 -o "$HOOKLIBCR.1.0.0"
|
|
gcc -shared -Wl,-soname,librunc-hooks-create-container.so.1 -o "$HOOKLIBCC.1.0.0"
|
|
|
|
current_pwd="$(pwd)"
|
|
|
|
# To mount $HOOKLIBCR we need to do that in the container namespace
|
|
create_runtime_hook=$(
|
|
cat <<-EOF
|
|
pid=\$(cat - | jq -r '.pid')
|
|
touch "$LIBPATH/$HOOKLIBCR.1.0.0"
|
|
nsenter -m \$ns -t \$pid mount --bind "$current_pwd/$HOOKLIBCR.1.0.0" "$LIBPATH/$HOOKLIBCR.1.0.0"
|
|
EOF
|
|
)
|
|
|
|
create_container_hook="touch ./lib/$HOOKLIBCC.1.0.0 && mount --bind $current_pwd/$HOOKLIBCC.1.0.0 ./lib/$HOOKLIBCC.1.0.0"
|
|
|
|
CONFIG=$(jq --arg create_runtime_hook "$create_runtime_hook" --arg create_container_hook "$create_container_hook" '
|
|
.hooks |= . + {"createRuntime": [{"path": "/bin/sh", "args": ["/bin/sh", "-c", $create_runtime_hook]}]} |
|
|
.hooks |= . + {"createContainer": [{"path": "/bin/sh", "args": ["/bin/sh", "-c", $create_container_hook]}]} |
|
|
.hooks |= . + {"startContainer": [{"path": "/bin/sh", "args": ["/bin/sh", "-c", "ldconfig"]}]} |
|
|
.root.readonly |= false |
|
|
.process.args = ["/bin/sh", "-c", "ldconfig -p | grep librunc"]' "$DEBIAN_BUNDLE"/config.json)
|
|
echo "${CONFIG}" >config.json
|
|
|
|
runc run test_debian
|
|
[ "$status" -eq 0 ]
|
|
|
|
echo "Checking create-runtime library"
|
|
echo "$output" | grep $HOOKLIBCR
|
|
|
|
echo "Checking create-container library"
|
|
echo "$output" | grep $HOOKLIBCC
|
|
}
|