Aleksa Sarai 8da42aaec2 sync: split init config (stream) and synchronisation (seqpacket) pipes ...

We have different requirements for the initial configuration and
initWaiter pipe (just send netlink and JSON blobs with no complicated
handling needed for message coalescing) and the packet-based
synchronisation pipe.

Tests with switching everything to SOCK_SEQPACKET lead to endless issues
with runc hanging on start-up because random things would try to do
short reads (which SOCK_SEQPACKET will not allow and the Go stdlib
explicitly treats as a streaming source), so splitting it was the only
reasonable solution. Even doing somewhat dodgy tricks such as adding a
Read() wrapper which actually calls ReadPacket() and makes it seem like
a stream source doesn't work -- and is a bit too magical.

One upside is that doing it this way makes the difference between the
modes clearer -- INITPIPE is still used for initWaiter syncrhonisation
but aside from that all other synchronisation is done by SYNCPIPE.

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>

2023-09-24 20:31:14 +08:00

..

cmsg.go

libcontainer: sync: cleanup synchronisation code

2023-08-15 19:54:24 -07:00

utils_test.go

libct/utils: SearchLabels: optimize

2022-01-26 14:01:11 -08:00

utils_unix.go

sync: split init config (stream) and synchronisation (seqpacket) pipes

2023-09-24 20:31:14 +08:00

utils.go

sync: split init config (stream) and synchronisation (seqpacket) pipes

2023-09-24 20:31:14 +08:00