mirror of
https://github.com/opencontainers/runc.git
synced 2026-07-10 21:53:57 +08:00
8e8b136c49
With the idmap work, we will have a tainted Go thread in our thread-group that has a different mount namespace to the other threads. It seems that (due to some bad luck) the Go scheduler tends to make this thread the thread-group leader in our tests, which results in very baffling failures where /proc/self/mountinfo produces gibberish results. In order to avoid this, switch to using /proc/thread-self for everything that is thread-local. This primarily includes switching all file descriptor paths (CLONE_FS), all of the places that check the current cgroup (technically we never will run a single runc thread in a separate cgroup, but better to be safe than sorry), and the aforementioned mountinfo code. We don't need to do anything for the following because the results we need aren't thread-local: * Checks that certain namespaces are supported by stat(2)ing /proc/self/ns/... * /proc/self/exe and /proc/self/cmdline are not thread-local. * While threads can be in different cgroups, we do not do this for the runc binary (or libcontainer) and thus we do not need to switch to the thread-local version of /proc/self/cgroups. * All of the CLONE_NEWUSER files are not thread-local because you cannot set the usernamespace of a single thread (setns(CLONE_NEWUSER) is blocked for multi-threaded programs). Note that we have to use runtime.LockOSThread when we have an open handle to a tid-specific procfs file that we are operating on multiple times. Go can reschedule us such that we are running on a different thread and then kill the original thread (causing -ENOENT or similarly confusing errors). This is not strictly necessary for most usages of /proc/thread-self (such as using /proc/thread-self/fd/$n directly) since only operating on the actual inodes associated with the tid requires this locking, but because of the pre-3.17 fallback for CentOS, we have to do this in most cases. In addition, CentOS's kernel is too old for /proc/thread-self, which requires us to emulate it -- however in rootfs_linux.go, we are in the container pid namespace but /proc is the host's procfs. This leads to the incredibly frustrating situation where there is no way (on pre-4.1 Linux) to figure out which /proc/self/task/... entry refers to the current tid. We can just use /proc/self in this case. Yes this is all pretty ugly. I also wish it wasn't necessary. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
260 lines
7.7 KiB
Go
260 lines
7.7 KiB
Go
package libcontainer
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"io/fs"
|
|
"os"
|
|
"strconv"
|
|
|
|
"github.com/sirupsen/logrus"
|
|
"golang.org/x/sys/unix"
|
|
|
|
"github.com/opencontainers/runc/libcontainer/configs"
|
|
"github.com/opencontainers/runc/libcontainer/userns"
|
|
"github.com/opencontainers/runc/libcontainer/utils"
|
|
)
|
|
|
|
// mountSourceType indicates what type of file descriptor is being returned. It
|
|
// is used to tell rootfs_linux.go whether or not to use move_mount(2) to
|
|
// install the mount.
|
|
type mountSourceType string
|
|
|
|
const (
|
|
// An open_tree(2)-style file descriptor that needs to be installed using
|
|
// move_mount(2) to install.
|
|
mountSourceOpenTree mountSourceType = "open_tree"
|
|
// A plain file descriptor that can be mounted through /proc/thread-self/fd.
|
|
mountSourcePlain mountSourceType = "plain-open"
|
|
)
|
|
|
|
type mountSource struct {
|
|
Type mountSourceType `json:"type"`
|
|
file *os.File `json:"-"`
|
|
}
|
|
|
|
// mountError holds an error from a failed mount or unmount operation.
|
|
type mountError struct {
|
|
op string
|
|
source string
|
|
srcFile *mountSource
|
|
target string
|
|
dstFd string
|
|
flags uintptr
|
|
data string
|
|
err error
|
|
}
|
|
|
|
// Error provides a string error representation.
|
|
func (e *mountError) Error() string {
|
|
out := e.op + " "
|
|
|
|
if e.source != "" {
|
|
out += "src=" + e.source + ", "
|
|
if e.srcFile != nil {
|
|
out += "srcType=" + string(e.srcFile.Type) + ", "
|
|
out += "srcFd=" + strconv.Itoa(int(e.srcFile.file.Fd())) + ", "
|
|
}
|
|
}
|
|
out += "dst=" + e.target
|
|
if e.dstFd != "" {
|
|
out += ", dstFd=" + e.dstFd
|
|
}
|
|
|
|
if e.flags != uintptr(0) {
|
|
out += ", flags=0x" + strconv.FormatUint(uint64(e.flags), 16)
|
|
}
|
|
if e.data != "" {
|
|
out += ", data=" + e.data
|
|
}
|
|
|
|
out += ": " + e.err.Error()
|
|
return out
|
|
}
|
|
|
|
// Unwrap returns the underlying error.
|
|
// This is a convention used by Go 1.13+ standard library.
|
|
func (e *mountError) Unwrap() error {
|
|
return e.err
|
|
}
|
|
|
|
// mount is a simple unix.Mount wrapper, returning an error with more context
|
|
// in case it failed.
|
|
func mount(source, target, fstype string, flags uintptr, data string) error {
|
|
return mountViaFds(source, nil, target, "", fstype, flags, data)
|
|
}
|
|
|
|
// mountViaFds is a unix.Mount wrapper which uses srcFile instead of source,
|
|
// and dstFd instead of target, unless those are empty.
|
|
//
|
|
// If srcFile is non-nil and flags does not contain MS_REMOUNT, mountViaFds
|
|
// will mount it according to the mountSourceType of the file descriptor.
|
|
//
|
|
// The dstFd argument, if non-empty, is expected to be in the form of a path to
|
|
// an opened file descriptor on procfs (i.e. "/proc/thread-self/fd/NN").
|
|
//
|
|
// If a file descriptor is used instead of a source or a target path, the
|
|
// corresponding path is only used to add context to an error in case the mount
|
|
// operation has failed.
|
|
func mountViaFds(source string, srcFile *mountSource, target, dstFd, fstype string, flags uintptr, data string) error {
|
|
// MS_REMOUNT and srcFile don't make sense together.
|
|
if srcFile != nil && flags&unix.MS_REMOUNT != 0 {
|
|
logrus.Debugf("mount source passed along with MS_REMOUNT -- ignoring srcFile")
|
|
srcFile = nil
|
|
}
|
|
dst := target
|
|
if dstFd != "" {
|
|
dst = dstFd
|
|
}
|
|
src := source
|
|
isMoveMount := srcFile != nil && srcFile.Type == mountSourceOpenTree
|
|
if srcFile != nil {
|
|
// If we're going to use the /proc/thread-self/... path for classic
|
|
// mount(2), we need to get a safe handle to /proc/thread-self. This
|
|
// isn't needed for move_mount(2) because in that case the path is just
|
|
// a dummy string used for error info.
|
|
fdStr := strconv.Itoa(int(srcFile.file.Fd()))
|
|
if isMoveMount {
|
|
src = "/proc/self/fd/" + fdStr
|
|
} else {
|
|
var closer utils.ProcThreadSelfCloser
|
|
src, closer = utils.ProcThreadSelf("fd/" + fdStr)
|
|
defer closer()
|
|
}
|
|
}
|
|
|
|
var op string
|
|
var err error
|
|
if isMoveMount {
|
|
op = "move_mount"
|
|
err = unix.MoveMount(int(srcFile.file.Fd()), "",
|
|
unix.AT_FDCWD, dstFd,
|
|
unix.MOVE_MOUNT_F_EMPTY_PATH|unix.MOVE_MOUNT_T_SYMLINKS)
|
|
} else {
|
|
op = "mount"
|
|
err = unix.Mount(src, dst, fstype, flags, data)
|
|
}
|
|
if err != nil {
|
|
return &mountError{
|
|
op: op,
|
|
source: source,
|
|
srcFile: srcFile,
|
|
target: target,
|
|
dstFd: dstFd,
|
|
flags: flags,
|
|
data: data,
|
|
err: err,
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// unmount is a simple unix.Unmount wrapper.
|
|
func unmount(target string, flags int) error {
|
|
err := unix.Unmount(target, flags)
|
|
if err != nil {
|
|
return &mountError{
|
|
op: "unmount",
|
|
target: target,
|
|
flags: uintptr(flags),
|
|
err: err,
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// syscallMode returns the syscall-specific mode bits from Go's portable mode bits.
|
|
// Copy from https://cs.opensource.google/go/go/+/refs/tags/go1.20.7:src/os/file_posix.go;l=61-75
|
|
func syscallMode(i fs.FileMode) (o uint32) {
|
|
o |= uint32(i.Perm())
|
|
if i&fs.ModeSetuid != 0 {
|
|
o |= unix.S_ISUID
|
|
}
|
|
if i&fs.ModeSetgid != 0 {
|
|
o |= unix.S_ISGID
|
|
}
|
|
if i&fs.ModeSticky != 0 {
|
|
o |= unix.S_ISVTX
|
|
}
|
|
// No mapping for Go's ModeTemporary (plan9 only).
|
|
return
|
|
}
|
|
|
|
// mountFd creates a "mount source fd" (either through open_tree(2) or just
|
|
// open(O_PATH)) based on the provided configuration. This function must be
|
|
// called from within the container's mount namespace.
|
|
//
|
|
// In the case of idmapped mount configurations, the returned mount source will
|
|
// be an open_tree(2) file with MOUNT_ATTR_IDMAP applied. For other
|
|
// bind-mounts, it will be an O_PATH. If the type of mount cannot be handled,
|
|
// the returned mountSource will be nil, indicating that the container init
|
|
// process will need to do an old-fashioned mount(2) themselves.
|
|
//
|
|
// This helper is only intended to be used by goCreateMountSources.
|
|
func mountFd(nsHandles *userns.Handles, m *configs.Mount) (*mountSource, error) {
|
|
if !m.IsBind() {
|
|
return nil, errors.New("new mount api: only bind-mounts are supported")
|
|
}
|
|
if nsHandles == nil {
|
|
nsHandles = new(userns.Handles)
|
|
defer nsHandles.Release()
|
|
}
|
|
|
|
var mountFile *os.File
|
|
var sourceType mountSourceType
|
|
|
|
// Ideally, we would use OPEN_TREE_CLONE for everything, because we can
|
|
// be sure that the file descriptor cannot be used to escape outside of
|
|
// the mount root. Unfortunately, OPEN_TREE_CLONE is far more expensive
|
|
// than open(2) because it requires doing mounts inside a new anonymous
|
|
// mount namespace. So we use open(2) for standard bind-mounts, and
|
|
// OPEN_TREE_CLONE when we need to set mount attributes here.
|
|
//
|
|
// While passing open(2)'d paths from the host rootfs isn't exactly the
|
|
// safest thing in the world, the files will not survive across
|
|
// execve(2) and "runc init" is non-dumpable so it should not be
|
|
// possible for a malicious container process to gain access to the
|
|
// file descriptors. We also don't do any of this for "runc exec",
|
|
// lessening the risk even further.
|
|
if m.IsIDMapped() {
|
|
flags := uint(unix.OPEN_TREE_CLONE | unix.OPEN_TREE_CLOEXEC)
|
|
if m.Flags&unix.MS_REC == unix.MS_REC {
|
|
flags |= unix.AT_RECURSIVE
|
|
}
|
|
fd, err := unix.OpenTree(unix.AT_FDCWD, m.Source, flags)
|
|
if err != nil {
|
|
return nil, &os.PathError{Op: "open_tree(OPEN_TREE_CLONE)", Path: m.Source, Err: err}
|
|
}
|
|
mountFile = os.NewFile(uintptr(fd), m.Source)
|
|
sourceType = mountSourceOpenTree
|
|
|
|
// Configure the id mapping.
|
|
usernsFile, err := nsHandles.Get(userns.Mapping{
|
|
UIDMappings: m.UIDMappings,
|
|
GIDMappings: m.GIDMappings,
|
|
})
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to create userns for %s id-mapping: %w", m.Source, err)
|
|
}
|
|
defer usernsFile.Close()
|
|
|
|
if err := unix.MountSetattr(int(mountFile.Fd()), "", unix.AT_EMPTY_PATH, &unix.MountAttr{
|
|
Attr_set: unix.MOUNT_ATTR_IDMAP,
|
|
Userns_fd: uint64(usernsFile.Fd()),
|
|
}); err != nil {
|
|
return nil, fmt.Errorf("failed to set MOUNT_ATTR_IDMAP on %s: %w", m.Source, err)
|
|
}
|
|
} else {
|
|
var err error
|
|
mountFile, err = os.OpenFile(m.Source, unix.O_PATH|unix.O_CLOEXEC, 0)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
sourceType = mountSourcePlain
|
|
}
|
|
return &mountSource{
|
|
Type: sourceType,
|
|
file: mountFile,
|
|
}, nil
|
|
}
|