Kir Kolyshkin
5026bfab9c
TL;DR: this allows to show logs from failed runc restore. Bats scripts are run with `set -e`. This is well known and obvious, and yet there are a few errors with respect to that, including a few "gems" by yours truly. 1. bats scripts are run with `set -e`, meaning that `[ $? -eq 0 ]` is useless since the execution won't ever reach this line in case of non-zero exit code from a preceding command. So, remove all such checks, they are useless and misleading. 2. bats scripts are run with `set -e`, meaning that `ret=$?` is useless since the execution won't ever reach this line in case of non-zero exit code from a preceding command. In particular, the code that calls runc restore needs to save the exit code, show the errors in the log, and only when check the exit code and fail if it's non-zero. It can not use `run` (or `runc` which uses `run`) because of shell redirection that we need to set up. The solution, implemented in this patch, is to use code like this: ```bash ret=0 __runc ... || ret=$? show_logs [ $ret -eq 0 ] ``` In case __runc exits with non-zero exit code, `ret=$?` is executed, and it always succeeds, so we won't fail just yet and have a chance to show logs before checking the value of $ret. In case __runc succeeds, `ret=$?` is never executed, so $ret will still be zero (this is the reason why it needs to be set explicitly). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
runc Integration Tests
Integration tests provide end-to-end testing of runc.
Note that integration tests do not replace unit tests.
As a rule of thumb, code should be tested thoroughly with unit tests. Integration tests on the other hand are meant to test a specific feature end to end.
Integration tests are written in bash using the bats framework.
Running integration tests
The easiest way to run integration tests is with Docker:
$ make integration
Alternatively, you can run integration tests directly on your host through make:
$ sudo make localintegration
Or you can just run them directly using bats
$ sudo bats tests/integration
To run a single test bucket:
$ make integration TESTPATH="/checkpoint.bats"
To run them on your host, you will need to setup a development environment plus bats For example:
$ cd ~/go/src/github.com
$ git clone https://github.com/sstephenson/bats.git
$ cd bats
$ ./install.sh /usr/local
Note
: There are known issues running the integration tests using devicemapper as a storage driver, make sure that your docker daemon is using aufs if you want to successfully run the integration tests.
Writing integration tests
[helper functions] (https://github.com/opencontainers/runc/blob/master/tests/integration/helpers.bash) are provided in order to facilitate writing tests.
#!/usr/bin/env bats
# This will load the helpers.
load helpers
# setup is called at the beginning of every test.
function setup() {
# see functions teardown_hello and setup_hello in helpers.bash, used to
# create a pristine environment for running your tests
teardown_hello
setup_hello
}
# teardown is called at the end of every test.
function teardown() {
teardown_hello
}
@test "this is a simple test" {
runc run containerid
# "The runc macro" automatically populates $status, $output and $lines.
# Please refer to bats documentation to find out more.
[ "$status" -eq 0 ]
# check expected output
[[ "${output}" == *"Hello"* ]]
}