mirror of
https://github.com/opencontainers/runc.git
synced 2026-07-11 14:13:58 +08:00
Kir Kolyshkin
524abc59f4
I hate to keep adding those kludges, but lately TestFreeze (and TestSystemdFreeze) from libcontainer/integration fails a lot. The failure comes and goes, and is probably this is caused by a slow host allocated for the test, and a slow VM on top of it. To remediate, add a small sleep on every 25th iteration in between asking the kernel to freeze and checking its status. In the worst case scenario (failure to freeze), this adds about 0.4 ms (40 x 10 us) to the duration of the call. It is hard to measure how this affects CI as GHA plays a roulette when allocating a node to run the test on, but it seems to help. With additional debug info, I saw somewhat frequent "frozen after 24 retries" or "frozen after 49 retries", meaning it succeeded right after the added sleep. While at it, rewrite/improve the comments. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>