Kir Kolyshkin dcf1b731f5 runc kill: fix sending KILL to non-pidns container ...

Commit f8ad20f made it impossible to kill leftover processes in a
stopped container that does not have its own PID namespace. In other
words, if a container init is gone, it is no longer possible to use
`runc kill` to kill the leftover processes.

Fix this by moving the check if container init exists to after the
special case of handling the container without own PID namespace.

While at it, fix the minor issue introduced by commit 9583b3d:
if signalAllProcesses is used, there is no need to thaw the
container (as freeze/thaw is either done in signalAllProcesses already,
or not needed at all).

Also, make signalAllProcesses return an error early if the container
cgroup does not exist (as it relies on it to do its job). This way, the
error message returned is more generic and easier to understand
("container not running" instead of "can't open file").

Finally, add a test case.

Fixes: f8ad20f
Fixes: 9583b3d
Co-authored-by: lifubang <lifubang@acmcoder.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

2023-11-27 09:15:39 -08:00

..

fuzzing

tests: Fix fuzzer location in oss-fuzz config

2023-03-23 03:21:17 +08:00

integration

runc kill: fix sending KILL to non-pidns container

2023-11-27 09:15:39 -08:00

rootless.sh

tests/rootless.sh: drop set -x

2023-06-08 09:23:29 -07:00