runc/libcontainer/intelrdt at feff2c451ecd2d27ac176da522380a472848bd2e - runc

mirror of https://github.com/opencontainers/runc.git synced 2026-07-11 06:03:57 +08:00

Files

T

Kir Kolyshkin feff2c451e libct/intelrdt: fix potential nil dereference

In case getIntelRdtData() returns an error, d is set to nil.

In case the error returned is of NotFoundError type (which happens
if resctlr mount is not found in /proc/self/mountinfo), the function
proceeds to call d.join(), resulting in a nil deref and a panic.

In practice, this never happens in runc because of the checks in
intelrdt() function in libcontainer/configs/validate, which raises
an error in case any of the parameters are set in config but
the IntelRTD itself is not available (that includes checking
that the mount point is there).

Nevertheless, the code is wrong, and can result in nil dereference
if some external users uses Apply on a system without resctrl mount.

Fix this by removing the exclusion.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

2021-06-28 12:45:28 -07:00

cmt_test.go

intelrdt: Add Cache Monitoring Technology stats

2020-04-25 09:43:48 +02:00

cmt.go

Use gofumpt to format code

2021-06-01 12:17:27 -07:00

intelrdt_test.go

libct/intelrdt: fix unit test

2021-05-05 14:07:10 -07:00

intelrdt.go

libct/intelrdt: fix potential nil dereference