libct: rm eaccess

It is not needed since Go 1.20 (which was released in February 2023 and
is no longer supported since February 2024).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

libcontainer/eaccess_go119.go

@@ -1,17 +0,0 @@
-//go:build !go1.20
-// +build !go1.20
-
-package libcontainer
-
-import "golang.org/x/sys/unix"
-
-func eaccess(path string) error {
-	// This check is similar to access(2) with X_OK except for
-	// setuid/setgid binaries where it checks against the effective
-	// (rather than real) uid and gid. It is not needed in go 1.20
-	// and beyond and will be removed later.
-
-	// Relies on code added in https://go-review.googlesource.com/c/sys/+/468877
-	// and older CLs linked from there.
-	return unix.Faccessat(unix.AT_FDCWD, path, unix.X_OK, unix.AT_EACCESS)
-}

libcontainer/eaccess_stub.go

@@ -1,10 +0,0 @@
-//go:build go1.20
-
-package libcontainer
-
-func eaccess(path string) error {
-	// Not needed in Go 1.20+ as the functionality is already in there
-	// (added by https://go.dev/cl/416115, https://go.dev/cl/414824,
-	// and fixed in Go 1.20.2 by https://go.dev/cl/469956).
-	return nil
-}

libcontainer/setns_init_linux.go

@@ -117,13 +117,6 @@ func (l *linuxSetnsInit) Init() error {
 	if err != nil {
 		return err
 	}
-	// exec.LookPath in Go < 1.20 might return no error for an executable
-	// residing on a file system mounted with noexec flag, so perform this
-	// extra check now while we can still return a proper error.
-	// TODO: remove this once go < 1.20 is not supported.
-	if err := eaccess(name); err != nil {
-		return &os.PathError{Op: "eaccess", Path: name, Err: err}
-	}
 	// Set seccomp as close to execve as possible, so as few syscalls take
 	// place afterward (reducing the amount of syscalls that users need to
 	// enable in their seccomp profiles).

libcontainer/standard_init_linux.go

@@ -211,13 +211,6 @@ func (l *linuxStandardInit) Init() error {
 	if err != nil {
 		return err
 	}
-	// exec.LookPath in Go < 1.20 might return no error for an executable
-	// residing on a file system mounted with noexec flag, so perform this
-	// extra check now while we can still return a proper error.
-	// TODO: remove this once go < 1.20 is not supported.
-	if err := eaccess(name); err != nil {
-		return &os.PathError{Op: "eaccess", Path: name, Err: err}
-	}
 
 	// Set seccomp as close to execve as possible, so as few syscalls take
 	// place afterward (reducing the amount of syscalls that users need to