Merge pull request #3192 from kinvolk/rata/cgo-warnings

CI: Mark CGO warnings as errors

.github/workflows/test.yml

@@ -11,6 +11,10 @@ on:
       - release-*
   pull_request:
 
+env:
+  # Don't ignore C warnings. Note that the output of "go env CGO_CFLAGS" by default is "-g -O2", so we keep them.
+  CGO_CFLAGS: -g -O2 -Werror
+
 jobs:
   test:
     runs-on: ubuntu-20.04

.github/workflows/validate.yml

@@ -25,6 +25,9 @@ jobs:
 
   compile-buildtags:
     runs-on: ubuntu-20.04
+    env:
+      # Don't ignore C warnings. Note that the output of "go env CGO_CFLAGS" by default is "-g -O2", so we keep them.
+      CGO_CFLAGS: -g -O2 -Werror
     steps:
       - uses: actions/checkout@v2
       - name: compile with no build tags