mirror of
https://github.com/opencontainers/runc.git
synced 2026-07-11 06:03:57 +08:00
c3ffd2ef81
bfq weight controller (i.e. io.bfq.weight if present) is still using the same bfq weight scheme (i.e 1->1000, see [1].) Unfortunately the documentation for this was wrong, and only fixed recently [2]. Therefore, if we map blkio weight to io.bfq.weight, there's no need to do any conversion. Otherwise, we will try to write invalid value which results in error such as: ``` time="2021-02-03T14:55:30Z" level=error msg="container_linux.go:367: starting container process caused: process_linux.go:495: container init caused: process_linux.go:458: setting cgroup config for procHooks process caused: failed to write \"7475\": write /sys/fs/cgroup/runc-cgroups-integration-test/test-cgroup/io.bfq.weight: numerical result out of range" ``` [1] https://github.com/torvalds/linux/blob/master/Documentation/block/bfq-iosched.rst [2] https://github.com/torvalds/linux/commit/65752aef0a407e1ef17ec78a7fc31ba4e0b360f9 Signed-off-by: Daniel Dao <dqminh89@gmail.com>
135 lines
3.2 KiB
Go
135 lines
3.2 KiB
Go
// +build linux
|
|
|
|
package fs2
|
|
|
|
import (
|
|
"bufio"
|
|
"os"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/opencontainers/runc/libcontainer/cgroups"
|
|
"github.com/opencontainers/runc/libcontainer/cgroups/fscommon"
|
|
"github.com/opencontainers/runc/libcontainer/configs"
|
|
)
|
|
|
|
func isIoSet(cgroup *configs.Cgroup) bool {
|
|
return cgroup.Resources.BlkioWeight != 0 ||
|
|
len(cgroup.Resources.BlkioThrottleReadBpsDevice) > 0 ||
|
|
len(cgroup.Resources.BlkioThrottleWriteBpsDevice) > 0 ||
|
|
len(cgroup.Resources.BlkioThrottleReadIOPSDevice) > 0 ||
|
|
len(cgroup.Resources.BlkioThrottleWriteIOPSDevice) > 0
|
|
}
|
|
|
|
func setIo(dirPath string, cgroup *configs.Cgroup) error {
|
|
if !isIoSet(cgroup) {
|
|
return nil
|
|
}
|
|
|
|
if cgroup.Resources.BlkioWeight != 0 {
|
|
filename := "io.bfq.weight"
|
|
if err := fscommon.WriteFile(dirPath, filename,
|
|
strconv.FormatUint(uint64(cgroup.Resources.BlkioWeight), 10)); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
for _, td := range cgroup.Resources.BlkioThrottleReadBpsDevice {
|
|
if err := fscommon.WriteFile(dirPath, "io.max", td.StringName("rbps")); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
for _, td := range cgroup.Resources.BlkioThrottleWriteBpsDevice {
|
|
if err := fscommon.WriteFile(dirPath, "io.max", td.StringName("wbps")); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
for _, td := range cgroup.Resources.BlkioThrottleReadIOPSDevice {
|
|
if err := fscommon.WriteFile(dirPath, "io.max", td.StringName("riops")); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
for _, td := range cgroup.Resources.BlkioThrottleWriteIOPSDevice {
|
|
if err := fscommon.WriteFile(dirPath, "io.max", td.StringName("wiops")); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func readCgroup2MapFile(dirPath string, name string) (map[string][]string, error) {
|
|
ret := map[string][]string{}
|
|
f, err := fscommon.OpenFile(dirPath, name, os.O_RDONLY)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer f.Close()
|
|
scanner := bufio.NewScanner(f)
|
|
for scanner.Scan() {
|
|
line := scanner.Text()
|
|
parts := strings.Fields(line)
|
|
if len(parts) < 2 {
|
|
continue
|
|
}
|
|
ret[parts[0]] = parts[1:]
|
|
}
|
|
if err := scanner.Err(); err != nil {
|
|
return nil, err
|
|
}
|
|
return ret, nil
|
|
}
|
|
|
|
func statIo(dirPath string, stats *cgroups.Stats) error {
|
|
// more details on the io.stat file format: https://www.kernel.org/doc/Documentation/cgroup-v2.txt
|
|
var ioServiceBytesRecursive []cgroups.BlkioStatEntry
|
|
values, err := readCgroup2MapFile(dirPath, "io.stat")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for k, v := range values {
|
|
d := strings.Split(k, ":")
|
|
if len(d) != 2 {
|
|
continue
|
|
}
|
|
major, err := strconv.ParseUint(d[0], 10, 0)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
minor, err := strconv.ParseUint(d[1], 10, 0)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
for _, item := range v {
|
|
d := strings.Split(item, "=")
|
|
if len(d) != 2 {
|
|
continue
|
|
}
|
|
op := d[0]
|
|
|
|
// Accommodate the cgroup v1 naming
|
|
switch op {
|
|
case "rbytes":
|
|
op = "read"
|
|
case "wbytes":
|
|
op = "write"
|
|
}
|
|
|
|
value, err := strconv.ParseUint(d[1], 10, 0)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
entry := cgroups.BlkioStatEntry{
|
|
Op: op,
|
|
Major: major,
|
|
Minor: minor,
|
|
Value: value,
|
|
}
|
|
ioServiceBytesRecursive = append(ioServiceBytesRecursive, entry)
|
|
}
|
|
}
|
|
stats.BlkioStats = cgroups.BlkioStats{IoServiceBytesRecursive: ioServiceBytesRecursive}
|
|
return nil
|
|
}
|